Use SDL_PollEvent instead of Event Filters#727
Open
tophyr wants to merge 1 commit intoDescentDevelopers:mainfrom
Open
Use SDL_PollEvent instead of Event Filters#727tophyr wants to merge 1 commit intoDescentDevelopers:mainfrom
tophyr wants to merge 1 commit intoDescentDevelopers:mainfrom
Conversation
SDL EventFilters were *always* the incorrect way to handle input, but now in SDL3 are even more incorrect as they run on the thread that accepts the input, not the thread that's intended to handle it. (This is a significant difference on Android and iOS.) The fix is surprisingly simple: Just poll for input in the OS defer handler. This is already called at the start of every type of every frame, so it is the perfect place to grab input.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Description
SDL EventFilters were always the incorrect way to handle input, but now in SDL3 are even more incorrect as they run on the thread that accepts the input, not the thread that's intended to handle it. (This is a significant difference on Android and iOS.)
The fix is surprisingly simple: Just poll for input in the OS defer handler. This is already called at the start of every type of every frame, so it is the perfect place to grab input.
Related Issues
Checklist